Page MenuHomePhabricator

Remove two problematic XML linter unit tests

Authored by epriestley on Aug 25 2015, 3:50 AM.



Fixes T7215. See D13991. These test cases have been failing intermittently for a while.

I think the XML stuff (which we don't control) changed where it raises these warnings: an old version raised them at the end of the attribute, while the new version raises them at the beginning of the attribute. Not totally 100% sure about this since installing multiple versions is fairly inconvenient, but as far as I know both versions raise the warnings, just at different character offsets.

We could do various things to fix these tests (allow the warning to raise at any character, skip the tests based on versions, etc) but I think it's easier to just remove the tests. They don't seem valuable.

Test Plan

Tests failed prior to change; now pass.

Diff Detail

rARC Arcanist
No Lint Coverage
No Test Coverage
Build Status
Buildable 7811
Build 8654: [Placeholder Plan] Wait for 30 Seconds
Build 8653: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Remove two problematic XML linter unit tests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.

arc diff didn't trigger the relevant tests for this, which I expected it to. I ran with arc unit --everything, but I'll see if I can figure out why the tests weren't auto-included...

This revision is now accepted and ready to land.Aug 25 2015, 3:52 AM
This revision was automatically updated to reflect the committed changes.