Page MenuHomePhabricator

Improvements to makefile
ClosedPublic

Authored by joshuaspence on Aug 23 2015, 9:59 AM.

Details

Summary

Various improvements to the XHPAST Makefile.

Test Plan
> make -C support/xhpast cleanall parser scanner xhpast
make: Entering directory '/home/joshua/workspace/github.com/phacility/libphutil/support/xhpast'
rm --force xhpast parser.yacc.output libxhpast.a *.o
rm --force scanner.lex.hpp scanner.lex.cpp parser.yacc.hpp parser.yacc.cpp
rm --force node_names.hpp parser_nodes.php
bison --verbose -Wall --defines=parser.yacc.hpp --output=parser.yacc.cpp parser.y
flex -CFr --header-file=scanner.lex.hpp --outfile=scanner.lex.cpp scanner.l
php -f generate_nodes.php
Wrote C++ definition.
Wrote PHP definition.
g++ -c -fPIC -Wall -O3 -minline-all-stringops -o scanner.lex.o scanner.lex.cpp
g++ -c -fPIC -Wall -O3 -minline-all-stringops -o parser.yacc.o parser.yacc.cpp
ar -crs libxhpast.a scanner.lex.o parser.yacc.o
g++ -fPIC -Wall -O3 -minline-all-stringops -o xhpast xhpast.cpp libxhpast.a
make: Leaving directory '/home/joshua/workspace/github.com/phacility/libphutil/support/xhpast'

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsupport/xhpast/Makefile:6TXT2Tab Literal
Unit
No Test Coverage
Build Status
Buildable 7831
Build 8694: [Placeholder Plan] Wait for 30 Seconds
Build 8693: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Improvements to makefile.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

Still a WIP.

This revision now requires changes to proceed.Aug 24 2015, 5:12 PM
joshuaspence edited edge metadata.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 29 2015, 12:30 PM
This revision was automatically updated to reflect the committed changes.