Differential D13961

Fix linter rule after XHPAST change
ClosedPublic
Actions

Authored by joshuaspence on Aug 22 2015, 1:50 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC18e32d6ec7f7: Fix linter rule after XHPAST change

Summary

Depends on D13959.

Test Plan

Ran unit tests.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7718
Build 8470: [Placeholder Plan] Wait for 30 Seconds
Build 8469: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33694.Aug 22 2015, 1:50 AM

joshuaspence retitled this revision from to Fix linter rule after XHPAST change.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D13959: Create operator nodes in ternary expressions.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 22 2015, 1:50 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 27 2015, 11:25 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 27 2015, 11:25 AM

Closed by commit rARC18e32d6ec7f7: Fix linter rule after XHPAST change (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 27 2015, 12:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

linter/

xhpast/

rules/

ArcanistPHPCompatibilityXHPASTLinterRule.php

2 lines

88%

Diff 33694

View Options

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

Fix linter rule after XHPAST changeClosedPublicActions