Page MenuHomePhabricator
Differential D13923

Show packages in table of contents views in Diffusion and Differential
ClosedPublic
Actions

Authored by epriestley on Aug 17 2015, 4:44 PM.
Tags
None
Referenced Files
F13214540: D13923.id33599.diff
Fri, May 17, 11:16 AM
F13212056: D13923.diff
Fri, May 17, 6:21 AM
F13201731: D13923.id33599.diff
Tue, May 14, 3:22 PM
F13195676: D13923.diff
Sun, May 12, 10:33 PM
F13179664: D13923.diff
Wed, May 8, 9:21 PM
Unknown Object (File)
Mon, May 6, 7:55 AM
Unknown Object (File)
Sat, May 4, 6:56 PM
Unknown Object (File)
Wed, May 1, 12:24 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8004: Highlight files owned by self/project when viewing revision
Commits
Restricted Diffusion Commit
rP6010e80e5c5a: Show packages in table of contents views in Diffusion and Differential
Summary

Fixes T8004.

  • For paths which are part of a package, show the package.
  • Highlight paths which are part of a package you (the viewer) have authority over.
Test Plan

Screen Shot 2015-08-17 at 9.39.21 AM.png (184×1 px, 20 KB)

  • Viewed owned and unowned chagnes in Diffusion and Differential.

Diff Detail

Repository
rP Phabricator
Branch
owners3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/controller/DifferentialController.php:55XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 7660
Build 8358: [Placeholder Plan] Wait for 30 Seconds
Build 8357: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33599.Aug 17 2015, 4:44 PM
epriestley retitled this revision from to Show packages in table of contents views in Diffusion and Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8004: Highlight files owned by self/project when viewing revision.
chad accepted this revision.Aug 17 2015, 5:12 PM
chad edited edge metadata.

el testo

This revision is now accepted and ready to land.Aug 17 2015, 5:12 PM
epriestley added a comment.Aug 17 2015, 5:13 PM

I tend to think these might be better with just an icon or something, but El Testo Packageo seemed to fit OK.

Closed by commit rP6010e80e5c5a: Show packages in table of contents views in Diffusion and Differential (authored by epriestley, committed by epriestley). · Explain WhyAug 17 2015, 5:14 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T1226: Phabricator audit queue: show which files are triggering the audit.May 17 2016, 2:03 PM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
42 lines
storage/
8 lines
diffusion/
controller/
38 lines
infrastructure/
diff/
view/
38 lines

Diff 33599

View Options

src/applications/differential/controller/DifferentialController.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php

Loading...
Phabricator · Built by Phacility