Page MenuHomePhabricator

Convert DifferentialDiff view to new PHUIDiffTableOfContentsListView
AbandonedPublic

Authored by epriestley on Aug 15 2015, 6:02 PM.
Tags
None
Referenced Files
F14110146: D13909.diff
Wed, Nov 27, 4:27 PM
Unknown Object (File)
Sun, Nov 24, 7:34 PM
Unknown Object (File)
Sat, Nov 23, 2:12 AM
Unknown Object (File)
Wed, Nov 20, 2:11 PM
Unknown Object (File)
Wed, Nov 20, 2:11 PM
Unknown Object (File)
Tue, Nov 19, 4:05 AM
Unknown Object (File)
Sat, Nov 9, 9:50 AM
Unknown Object (File)
Fri, Nov 8, 3:23 PM
Subscribers
None

Details

Summary

Ref T2183. Remove old Differential-specific stuff. Minor tweaks:

  • Hide coverage if no information is avialable.
  • Fix/tweak tooltips.
  • Share a little more code.
Test Plan

Viewed TOC in diffs and revisions.

Diff Detail

Repository
rP Phabricator
Branch
toc3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7645
Build 8328: [Placeholder Plan] Wait for 30 Seconds
Build 8327: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Convert DifferentialDiff view to new PHUIDiffTableOfContentsListView.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I'm generally pro-showing-empty-stuff-for-discovery, but I philosophically believe that the value of code coverage is dramatically overstated. Practically speaking, it's also not easy or reasonable to configure it for many projects.

chad edited edge metadata.
This revision is now accepted and ready to land.Aug 15 2015, 7:18 PM

This ended up as part of rP81493993, I don't remember if that was on purpose or not.