Differential D13906

Remove unused revisionID and whitespace properties from diff TOC view
ClosedPublic
Actions

Authored by epriestley on Aug 15 2015, 4:53 PM.

Details

Reviewers

chad

Maniphest Tasks

T2183: unify "table of contents" views between Differential and Diffusion

Commits

Restricted Diffusion Commit
rPbb0d13345d6a: Remove unused revisionID and whitespace properties from diff TOC view

Summary

Ref T2183. These properties are not used and not useful.

Test Plan

Grepped for callsites and uses. Loaded revisions.

Diff Detail

Repository

rP Phabricator

Branch

toc1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7642
Build 8322: [Placeholder Plan] Wait for 30 Seconds
Build 8321: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33566.Aug 15 2015, 4:53 PM

epriestley retitled this revision from to Remove unused revisionID and whitespace properties from diff TOC view.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T2183: unify "table of contents" views between Differential and Diffusion.

chad accepted this revision.Aug 15 2015, 5:39 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 15 2015, 5:39 PM

Closed by commit rPbb0d13345d6a: Remove unused revisionID and whitespace properties from diff TOC view (authored by epriestley, committed by epriestley). · Explain WhyAug 15 2015, 5:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

2 lines

view/

DifferentialDiffTableOfContentsView.php

12 lines

Diff 33566

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php