Page MenuHomePhabricator
Differential D13895

Improve linter handling of short array syntax
ClosedPublic
Actions

Authored by joshuaspence on Aug 14 2015, 3:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 3:47 AM
Unknown Object (File)
Wed, Dec 18, 6:56 PM
Unknown Object (File)
Sat, Dec 14, 1:44 PM
Unknown Object (File)
Fri, Dec 13, 9:09 PM
Unknown Object (File)
Thu, Dec 12, 11:55 AM
Unknown Object (File)
Thu, Dec 12, 12:15 AM
Unknown Object (File)
Thu, Nov 28, 2:15 PM
Unknown Object (File)
Thu, Nov 28, 11:44 AM
View All Files
Subscribers
agenticarus
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC27ec3a2e34aa: Improve linter handling of short array syntax
Summary

Currently, linting PHP short array syntax (i.e. [...]) throws an exception ("Expected open parentheses"). This diff relaxes some restrictions which prevent short array syntax from linting with ArcanistParenthesesSpacingXHPASTLinterRule.

Test Plan

Modified test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33543.Aug 14 2015, 3:26 AM
joshuaspence retitled this revision from to Improve linter handling of short array syntax.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 14 2015, 3:26 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 14 2015, 10:58 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 14 2015, 10:58 AM
agenticarus added a subscriber: agenticarus.Aug 18 2015, 11:10 AM
joshuaspence updated this revision to Diff 33640.Aug 19 2015, 5:38 AM
joshuaspence edited edge metadata.

Rebase

Closed by commit rARC27ec3a2e34aa: Improve linter handling of short array syntax (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 19 2015, 5:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33641

View Options

src/lint/linter/__tests__/xhpast/array-formatting.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistCallParenthesesXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistParenthesesSpacingXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility