Page MenuHomePhabricator
Differential D13880

Add some missing translation strings
ClosedPublic
Actions

Authored by joshuaspence on Aug 13 2015, 4:59 AM.
Tags
None
Referenced Files
F14761128: D13880.diff
Wed, Jan 22, 11:21 PM
Unknown Object (File)
Tue, Jan 21, 9:24 AM
Unknown Object (File)
Tue, Jan 14, 4:36 PM
Unknown Object (File)
Dec 10 2024, 11:31 AM
Unknown Object (File)
Dec 8 2024, 5:10 PM
Unknown Object (File)
Dec 5 2024, 8:51 AM
Unknown Object (File)
Nov 24 2024, 4:42 PM
Unknown Object (File)
Nov 21 2024, 11:34 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP7938d9a52960: Add some missing translation strings
Summary

Self explanatory.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7617
Build 8274: [Placeholder Plan] Wait for 30 Seconds
Build 8273: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33516.Aug 13 2015, 4:59 AM
joshuaspence retitled this revision from to Add some missing translation strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 13 2015, 4:59 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 13 2015, 1:57 PM
epriestley edited edge metadata.

I think elsewhere we've removed the number in the translated version. For example, instead of:

epriestley edited dependencies, added 2: a, b; removed 3: c, d, e.

...just:

epriestley edited dependencies, added: a, b; removed: c, d, e.

e.g., see the similar strings on lines 611-612. You'll need to %4$s, etc., to skip parameters.

This revision is now accepted and ready to land.Aug 13 2015, 1:57 PM
joshuaspence updated this revision to Diff 33528.Aug 13 2015, 9:43 PM
joshuaspence edited edge metadata.

Remove numbers

Closed by commit rP7938d9a52960: Add some missing translation strings (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 13 2015, 9:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
infrastructure/
internationalization/
translation/
8 lines0%
Loading...

Diff 33528

View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility