Page MenuHomePhabricator
Differential D13863

Various linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Aug 11 2015, 12:17 PM.
Tags
None
Referenced Files
F14361595: D13863.diff
Fri, Dec 20, 11:38 AM
F14355777: D13863.id33489.diff
Thu, Dec 19, 6:24 PM
Unknown Object (File)
Mon, Dec 16, 12:47 PM
Unknown Object (File)
Fri, Dec 13, 11:52 PM
Unknown Object (File)
Fri, Dec 13, 2:24 PM
Unknown Object (File)
Wed, Dec 11, 3:40 PM
Unknown Object (File)
Sat, Dec 7, 3:41 AM
Unknown Object (File)
Tue, Dec 3, 9:34 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP2cf9ded87892: Various linter fixes
Summary

Self explanatory.

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7587
Build 8214: [Placeholder Plan] Wait for 30 Seconds
Build 8213: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33479.Aug 11 2015, 12:17 PM
joshuaspence retitled this revision from to Various linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 12:17 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 11 2015, 12:29 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2015, 12:29 PM
Closed by commit rP2cf9ded87892: Various linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 11 2015, 12:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
aphront/
configuration/
15 lines0%
Loading...
applications/
conpherence/
__tests__/
14 lines0%
Loading...
differential/
conduit/
7 lines25%
Loading...
7 lines15%
Loading...
parser/
6 lines90%
Loading...
home/
controller/
2 lines0%
Loading...
passphrase/
controller/
7 lines2%
Loading...
project/
controller/
7 lines2%
Loading...
search/
engine/
2 lines2%
Loading...
uiexample/
examples/
3 lines1%
Loading...
infrastructure/
sms/
worker/
4 lines100%
Loading...
storage/
lisk/
__tests__/
19 lines100%
Loading...
util/
__tests__/
20 lines100%
Loading...
view/
9 lines0%
Loading...
__tests__/
2 lines94%
Loading...

Diff 33479

View Options

src/aphront/configuration/AphrontApplicationConfiguration.php

Loading...
View Options

src/applications/conpherence/__tests__/ConpherenceTestCase.php

Loading...
View Options

src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php

Loading...
View Options

src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php

Loading...
View Options

src/applications/differential/parser/DifferentialHunkParser.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialRevealController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnHideController.php

Loading...
View Options

src/applications/search/engine/PhabricatorElasticSearchEngine.php

Loading...
View Options

src/applications/uiexample/examples/PHUIButtonExample.php

Loading...
View Options

src/infrastructure/sms/worker/PhabricatorSMSWorker.php

Loading...
View Options

src/infrastructure/storage/lisk/__tests__/LiskChunkTestCase.php

Loading...
View Options

src/infrastructure/util/__tests__/PhabricatorHashTestCase.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
View Options

src/view/__tests__/PhabricatorUnitsTestCase.php

Loading...
Phabricator · Built by Phacility