Page MenuHomePhabricator

Preserve more information when merging coverage
ClosedPublic

Authored by epriestley on Aug 10 2015, 9:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 11:33 PM
Unknown Object (File)
Thu, Nov 14, 10:08 PM
Unknown Object (File)
Mon, Nov 11, 5:57 AM
Unknown Object (File)
Sun, Nov 10, 7:17 PM
Unknown Object (File)
Thu, Nov 7, 4:44 AM
Unknown Object (File)
Thu, Nov 7, 3:51 AM
Unknown Object (File)
Wed, Nov 6, 6:20 PM
Unknown Object (File)
Wed, Nov 6, 6:20 PM
Subscribers
None
Tokens
"Orange Medal" token, awarded by joshuaspence.

Details

Summary

Ref T8096. Each test reports coverage information, which we sometimes merge into a combined coverage report.

Usually, each test will report results for every line in the file, so if the file is 30 lines long, coverage is usually 30 characters long.

However, for whatever reason, tests might report results for only the first part of the file. This is allowed and we handle it properly.

Right now, if one test reports 10 lines of results and another reports 30 lines of results, we only use the first 10 lines of results. Instead, extend the merged coverage to include the extra 20 lines of results.

(This is an uncommon case which I only hit because I was manually banging on my keyboard to generate test data, but there's no reason not to handle it better.)

Test Plan

Used web UI, added + executed unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Preserve more information when merging coverage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2015, 10:27 PM
This revision was automatically updated to reflect the committed changes.