Page MenuHomePhabricator
Differential D13852

Read modern coverage information for tables of contents
ClosedPublic
Actions

Authored by epriestley on Aug 10 2015, 9:00 PM.
Tags
None
Referenced Files
F18619700: D13852.diff
Mon, Sep 15, 3:10 AM
F18498894: D13852.diff
Thu, Sep 4, 7:08 PM
F18239795: D13852.id33446.diff
Thu, Aug 21, 12:03 AM
F18234595: D13852.id33468.diff
Wed, Aug 20, 6:17 PM
F18234412: D13852.id.diff
Wed, Aug 20, 6:00 PM
F18234008: D13852.diff
Wed, Aug 20, 5:18 PM
F18200048: D13852.id.diff
Mon, Aug 18, 3:55 AM
F18193419: D13852.diff
Sun, Aug 17, 5:22 AM
View All Files
Subscribers
None
Tokens
"Pterodactyl" token, awarded by joshuaspence.

Details

Reviewers
chad
Maniphest Tasks
T8096: Improve Harbormaster UI/UX (v1)
Commits
Restricted Diffusion Commit
rP5485fb8aa9e7: Read modern coverage information for tables of contents
Summary

Ref T8096. This modernizes the last thing which was reading the old datasource.

Also fix a bug where it didn't work.

Test Plan

Screen Shot 2015-08-10 at 1.55.02 PM.png (180×1 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33446.Aug 10 2015, 9:00 PM
epriestley retitled this revision from to Read modern coverage information for tables of contents.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8096: Improve Harbormaster UI/UX (v1).
joshuaspence awarded a token.Aug 10 2015, 9:43 PM
chad accepted this revision.Aug 10 2015, 10:20 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2015, 10:20 PM
Closed by commit rP5485fb8aa9e7: Read modern coverage information for tables of contents (authored by epriestley, committed by epriestley). · Explain WhyAug 10 2015, 10:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33468

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/differential/view/DifferentialDiffTableOfContentsView.php

Loading...
Phabricator · Built by Phacility