Page MenuHomePhabricator
Differential D13841

Improve PHP compatibility linter
ClosedPublic
Actions

Authored by joshuaspence on Aug 10 2015, 10:06 AM.
Tags
None
Referenced Files
F13286485: D13841.diff
Tue, Jun 4, 7:18 AM
F13256697: D13841.diff
Sat, May 25, 4:06 PM
F13253875: D13841.diff
Sat, May 25, 3:00 AM
F13249625: D13841.id.diff
Fri, May 24, 9:50 AM
F13232857: D13841.diff
Tue, May 21, 1:31 AM
F13232619: D13841.id33440.diff
Tue, May 21, 1:25 AM
F13232618: D13841.id.diff
Tue, May 21, 1:25 AM
F13225753: D13841.id33440.diff
Sun, May 19, 5:12 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8674: ArcanistClassNameLiteralXHPASTLinterRule can produce incorrect results
Commits
rARCf43b74c6052f: Improve PHP compatibility linter
Summary

Ref T8674. Adds to ArcanistPHPCompatibilityXHPASTLinterRule such that an error is raised whenever self or $this is used in an anonymous closure prior to PHP 5.4.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/lint/linter/__tests__/xhpast/php54-features.lint-test:15TXT6Trailing Whitespace
Unit
Test Failures
Build Status
Buildable 7557
Build 8154: [Placeholder Plan] Wait for 30 Seconds
Build 8153: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
2,366 msArcanistJSHintLinterTestCase::Unknown Unit Message ("")
1,504 msArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
185 msArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
214 msArcanistChmodLinterTestCase::Unknown Unit Message ("")
501 msArcanistClosureLinterTestCase::Unknown Unit Message ("")
View Full Test Results (1 Failed · 50 Passed · 7 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 33422.Aug 10 2015, 10:06 AM
joshuaspence retitled this revision from to Improve PHP compatibility linter.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T8674: ArcanistClassNameLiteralXHPASTLinterRule can produce incorrect results.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 10 2015, 10:06 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 10 2015, 1:29 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2015, 1:29 PM
Closed by commit rARCf43b74c6052f: Improve PHP compatibility linter (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 10 2015, 8:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
lint/
linter/
__tests__/
xhpast/
17 lines--
xhpast/
rules/
46 lines88%
Loading...

Diff 33422

View Options

src/lint/linter/__tests__/xhpast/php54-features.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility