Page MenuHomePhabricator

Add a method to query whether an AASTNode is a descendent of another node
ClosedPublic

Authored by joshuaspence on Aug 7 2015, 3:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:44 PM
Unknown Object (File)
Sat, Nov 16, 3:40 PM
Unknown Object (File)
Tue, Nov 12, 3:10 PM
Unknown Object (File)
Mon, Nov 11, 5:56 AM
Unknown Object (File)
Mon, Nov 11, 5:56 AM
Unknown Object (File)
Sat, Nov 9, 5:21 AM
Unknown Object (File)
Sat, Nov 9, 4:19 AM
Unknown Object (File)
Fri, Nov 8, 12:02 AM
Subscribers

Details

Summary

Ref T8674. This implementation is not really very efficient, but I'll try to iterate on that.

Test Plan

See D13820.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Add a method to query whether an AASTNode is a descendent of another node.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Consider isDescendantOf($x) or hasDescendant($x) or isAncestorOf($x) or hasAncestor($x) or similar to make intent more clear -- I think this $x->isDescendant($y) can be reasonably be read as either "$x is a descendant of $y" or "$y is a descendant of $x".

Specifically, I would expect this to mean "$x is a descendant of $y", because most $x->is...() methods return information about $x, but it actually means "$y is a descendant of $x". I would perhaps call this method isAncestorOf($y). This makes the $x/$y relationship more clear, although I don't think X being an ancestor of itself is always intuitive (but I don't have a better term for it offhand).

This revision is now accepted and ready to land.Aug 8 2015, 4:47 PM
joshuaspence edited edge metadata.
This revision was automatically updated to reflect the committed changes.