Page MenuHomePhabricator
Differential D13808

Various linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Aug 6 2015, 2:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 9:12 PM
Unknown Object (File)
Fri, Apr 12, 7:18 PM
Unknown Object (File)
Fri, Apr 12, 7:18 PM
Unknown Object (File)
Fri, Apr 12, 7:05 PM
Unknown Object (File)
Fri, Apr 12, 6:38 PM
Unknown Object (File)
Thu, Apr 11, 8:29 AM
Unknown Object (File)
Tue, Apr 9, 6:19 AM
Unknown Object (File)
Thu, Mar 28, 6:08 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP79f2e81f38be: Various linter fixes
Summary

Self-explanatory.

Test Plan

Eyeball it.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7508
Build 8056: [Placeholder Plan] Wait for 30 Seconds
Build 8055: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33349.Aug 6 2015, 2:34 AM
joshuaspence retitled this revision from to Various linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 6 2015, 2:34 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 6 2015, 2:34 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 6 2015, 2:34 AM
Closed by commit rP79f2e81f38be: Various linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 8 2015, 12:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
scripts/
symbols/
2 lines--
src/
applications/
audit/
editor/
2 lines0%
Loading...
diffusion/
query/
2 lines0%
Loading...
maniphest/
conduit/
2 lines11%
Loading...
phame/
controller/
blog/
2 lines3%
Loading...
ponder/
controller/
2 lines1%
Loading...
infrastructure/
markup/
rule/
2 lines1%
Loading...
view/
phui/
calendar/
2 lines0%
Loading...

Diff 33349

View Options

scripts/symbols/import_repository_symbols.php

Loading...
View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...
View Options

src/applications/maniphest/conduit/ManiphestUpdateConduitAPIMethod.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogListController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionEditController.php

Loading...
View Options

src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
Phabricator · Built by Phacility