Page MenuHomePhabricator
Differential D13781

Fix undefined ACTION_BLOCK class constant in Herald
ClosedPublic
Actions

Authored by epriestley on Aug 3 2015, 10:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 4:18 PM
Unknown Object (File)
Fri, Dec 13, 12:15 AM
Unknown Object (File)
Tue, Dec 3, 5:33 PM
Unknown Object (File)
Tue, Dec 3, 5:33 PM
Unknown Object (File)
Tue, Dec 3, 5:27 PM
Unknown Object (File)
Tue, Dec 3, 5:07 PM
Unknown Object (File)
Tue, Dec 3, 6:05 AM
Unknown Object (File)
Tue, Dec 3, 12:32 AM
View All Files
Subscribers
None

Details

Reviewers
joshuaspence
chad
Maniphest Tasks
T9054: Undefined class constant ACTION_BLOCK
Commits
Restricted Diffusion Commit
rP46bd6b30f8fd: Fix undefined ACTION_BLOCK class constant in Herald
Summary

Fixes T9054. This didn't get fully cleaned up.

Test Plan

Edited several rules, saw actions faithfully represented.

Diff Detail

Repository
rP Phabricator
Branch
heraldui2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7475
Build 7990: [Placeholder Plan] Wait for 30 Seconds
Build 7989: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33285.Aug 3 2015, 10:45 PM
epriestley retitled this revision from to Fix undefined ACTION_BLOCK class constant in Herald.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad.
epriestley added a task: T9054: Undefined class constant ACTION_BLOCK.
chad accepted this revision.Aug 3 2015, 11:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2015, 11:50 PM
Closed by commit rP46bd6b30f8fd: Fix undefined ACTION_BLOCK class constant in Herald (authored by epriestley, committed by epriestley). · Explain WhyAug 4 2015, 12:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
action/
17 lines
adapter/
14 lines
controller/
24 lines

Diff 33285

View Options

src/applications/herald/action/HeraldAction.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
Phabricator · Built by Phacility