Updates Notifcations for handleRequest
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T8628: Modernize AphrontControllers to implement handleRequest
- Commits
- Restricted Diffusion Commit
rPf5be68c59c39: Update Notifications for handleRequest
Test as much as I could, mark all, view, lists.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- notifications-process
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7457 Build 7954: [Placeholder Plan] Wait for 30 Seconds Build 7953: arc lint + arc unit
Event Timeline
| src/applications/notification/controller/PhabricatorNotificationClearController.php | ||
|---|---|---|
| 8 | getStr() and getURIData() are not the same. getStr() reads values out of the query parameters, like /?chronoKey=123. getURIData() reads the route regexps. For example, a URI like /task/edit/123/?id=456 might return 123 from getURIData(), but 456 from getInt(). This should stay as getStr(). | |