Page MenuHomePhabricator
Differential D13765

Update Herald for handleRequest
ClosedPublic
Actions

Authored by chad on Aug 1 2015, 1:56 AM.
Tags
None
Referenced Files
F18084985: D13765.diff
Tue, Aug 5, 6:55 PM
F18084400: D13765.diff
Tue, Aug 5, 3:17 PM
F18083838: D13765.id33242.diff
Tue, Aug 5, 11:42 AM
F18033519: D13765.id.diff
Sun, Aug 3, 12:48 AM
F17982714: D13765.diff
Fri, Aug 1, 7:52 PM
F17949128: D13765.id33257.diff
Thu, Jul 31, 10:53 PM
F17949116: D13765.id33242.diff
Thu, Jul 31, 10:52 PM
F17863021: D13765.diff
Mon, Jul 28, 12:34 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rP6d59f3d1f2d4: Update Herald for handleRequest
Summary

Update Herald for handleRequest

Test Plan

New rule, test console, logs, lists.

Diff Detail

Repository
rP Phabricator
Branch
herald-process
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7455
Build 7950: [Placeholder Plan] Wait for 30 Seconds
Build 7949: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33242.Aug 1 2015, 1:56 AM
chad retitled this revision from to Update Herald for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 1 2015, 1:56 AM
chad added a task: T8628: Modernize AphrontControllers to implement handleRequest.Aug 1 2015, 5:02 PM
epriestley accepted this revision.Aug 1 2015, 10:38 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2015, 10:38 PM
Closed by commit rP6d59f3d1f2d4: Update Herald for handleRequest (authored by chad, committed by chad). · Explain WhyAug 1 2015, 10:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33242

View Options

src/applications/herald/controller/HeraldDisableController.php

Loading...
View Options

src/applications/herald/controller/HeraldNewController.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleListController.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/applications/herald/controller/HeraldTestConsoleController.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptListController.php

Loading...
Phabricator · Built by Phacility