Page MenuHomePhabricator

Remove extra `/phurl` in request url
AbandonedPublic

Authored by ox on Jul 30 2015, 12:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 1, 2:52 PM
Unknown Object (File)
Thu, Mar 28, 7:02 PM
Unknown Object (File)
Mar 15 2024, 11:13 AM
Unknown Object (File)
Mar 14 2024, 12:35 AM
Unknown Object (File)
Mar 6 2024, 4:51 AM
Unknown Object (File)
Mar 6 2024, 4:51 AM
Unknown Object (File)
Feb 8 2024, 12:20 AM
Unknown Object (File)
Feb 3 2024, 6:02 AM
Subscribers

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9009: Cannot comment on Phurl links
Summary

Should fix T9009

Test Plan

I cannot get Phabricator to run on my dev machine (OS X), but this should be correct.

Diff Detail

Repository
rP Phabricator
Branch
fix/phurl-commenting
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7448
Build 7936: [Placeholder Plan] Wait for 30 Seconds
Build 7935: arc lint + arc unit

Event Timeline

ox retitled this revision from to Remove extra `/phurl` in request url.
ox updated this object.
ox edited the test plan for this revision. (Show Details)
chad added inline comments.
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
48

I think you don't need the first / either

ox marked an inline comment as done.
ox edited edge metadata.

remove leading / as it was getting trimmed anyway

chad added a reviewer: chad.
This revision is now accepted and ready to land.Jul 30 2015, 3:18 AM

Although, looking at the code, PhabricatorPhurlCommentController doesn't exist either, nor the route.

But this change is correct!

I don't know enough PHP to really get what this app is doing, but I imagined some smart folks at Phacility had created a generic commenting service and I was just not seeing it. Thanks for the help!

epriestley added a reviewer: epriestley.

I cannot get Phabricator to run on my dev machine (OS X), but this should be correct.

Let's just wait for the normal dev process here.

This revision now requires changes to proceed.Jul 30 2015, 2:11 PM