Page MenuHomePhabricator

Allow upload of arbitrary text files
ClosedPublic

Authored by epriestley on Jul 28 2015, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 5:45 AM
Unknown Object (File)
Mon, Dec 16, 4:42 PM
Unknown Object (File)
Thu, Dec 12, 7:00 AM
Unknown Object (File)
Sun, Dec 8, 4:06 PM
Unknown Object (File)
Sun, Dec 8, 9:49 AM
Unknown Object (File)
Sat, Dec 7, 3:47 AM
Unknown Object (File)
Wed, Dec 4, 4:22 PM
Unknown Object (File)
Tue, Dec 3, 8:34 PM
Subscribers

Details

Summary

Fixes T8984. Because of how drag-and-drop upload works, the text file with content code is interpreted as a forbidden variable. Disable this check for the drop upload controller.

(The risk here is a general one where the controller redirects and bundles paramters; this controller does not do that, so it's safe to make this change.)

Test Plan

Uploaded a text file containing only the string "code" (no quotes) by using drag-and-drop.

Diff Detail

Repository
rP Phabricator
Branch
dropup
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7428
Build 7896: [Placeholder Plan] Wait for 30 Seconds
Build 7895: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow upload of arbitrary text files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 28 2015, 3:03 PM
This revision was automatically updated to reflect the committed changes.