Have Badges use getMostOpenPolicy for View
ClosedPublic
Actions

Authored by chad on Jul 24 2015, 4:40 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8938: Badges need to return getMostOpenPolicy()

Commits

Restricted Diffusion Commit
rP2ada395ea9d5: Have Badges use getMostOpenPolicy for View

Summary

Fixes T8938. Sets by default for new badges, getMostOpenPolicy. Removes ability to edit viewPolicy.

Test Plan

Create a new badge, see its public, assign it, log out, still able to view it.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33114.Jul 24 2015, 4:40 PM

chad retitled this revision from to Have Badges use getMostOpenPolicy for View.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8938: Badges need to return getMostOpenPolicy().

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 24 2015, 4:40 PM

In theory, there may exist some badges that got set to some restrictive view policy in the wild. I think you'd want to write a migration script to migrate these things to more open, except that's kind of funky. Anyway, just an FYI you probably already knew I guess...

This revision is now accepted and ready to land.Jul 24 2015, 5:44 PM