Page MenuHomePhabricator

Have Badges use getMostOpenPolicy for View
ClosedPublic

Authored by chad on Jul 24 2015, 4:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 4:47 AM
Unknown Object (File)
Tue, Mar 5, 6:58 PM
Unknown Object (File)
Feb 11 2024, 3:13 PM
Unknown Object (File)
Feb 9 2024, 4:16 PM
Unknown Object (File)
Feb 9 2024, 4:16 PM
Unknown Object (File)
Feb 9 2024, 4:02 PM
Unknown Object (File)
Feb 9 2024, 3:53 PM
Unknown Object (File)
Feb 9 2024, 3:27 PM
Subscribers

Details

Summary

Fixes T8938. Sets by default for new badges, getMostOpenPolicy. Removes ability to edit viewPolicy.

Test Plan

Create a new badge, see its public, assign it, log out, still able to view it.

Diff Detail

Repository
rP Phabricator
Branch
badges-policy
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7379
Build 7798: [Placeholder Plan] Wait for 30 Seconds
Build 7797: arc lint + arc unit

Event Timeline

chad retitled this revision from to Have Badges use getMostOpenPolicy for View.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
btrahan edited edge metadata.

In theory, there may exist some badges that got set to some restrictive view policy in the wild. I think you'd want to write a migration script to migrate these things to more open, except that's kind of funky. Anyway, just an FYI you probably already knew I guess...

This revision is now accepted and ready to land.Jul 24 2015, 5:44 PM

We should also drop the column in the table at some point.

Yeah, nothing reads it anymore. Policy infrastructure doesn't depend on it existing because some objects don't have an editable view policy.

This revision was automatically updated to reflect the committed changes.