Page MenuHomePhabricator

Have Badges use getMostOpenPolicy for View
ClosedPublic

Authored by chad on Jul 24 2015, 4:40 PM.

Details

Summary

Fixes T8938. Sets by default for new badges, getMostOpenPolicy. Removes ability to edit viewPolicy.

Test Plan

Create a new badge, see its public, assign it, log out, still able to view it.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad updated this revision to Diff 33114.Jul 24 2015, 4:40 PM
chad retitled this revision from to Have Badges use getMostOpenPolicy for View.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
btrahan accepted this revision.Jul 24 2015, 5:44 PM
btrahan edited edge metadata.

In theory, there may exist some badges that got set to some restrictive view policy in the wild. I think you'd want to write a migration script to migrate these things to more open, except that's kind of funky. Anyway, just an FYI you probably already knew I guess...

This revision is now accepted and ready to land.Jul 24 2015, 5:44 PM
epriestley edited edge metadata.Jul 24 2015, 5:54 PM

We should also drop the column in the table at some point.

chad added a comment.Jul 24 2015, 5:55 PM

oh, i can drop the column?

Yeah, nothing reads it anymore. Policy infrastructure doesn't depend on it existing because some objects don't have an editable view policy.

chad added a comment.Jul 24 2015, 6:03 PM

will follow up

This revision was automatically updated to reflect the committed changes.