Page MenuHomePhabricator
Differential D13682

Update Phriction for handleRequest
ClosedPublic
Actions

Authored by chad on Jul 22 2015, 7:46 PM.
Tags
None
Referenced Files
F13165320: D13682.diff
Tue, May 7, 5:18 AM
Unknown Object (File)
Fri, May 3, 2:39 AM
Unknown Object (File)
Mon, Apr 29, 2:12 PM
Unknown Object (File)
Wed, Apr 24, 10:15 PM
Unknown Object (File)
Mon, Apr 22, 8:27 AM
Unknown Object (File)
Mon, Apr 22, 8:26 AM
Unknown Object (File)
Mon, Apr 22, 8:26 AM
Unknown Object (File)
Fri, Apr 12, 12:42 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rP96cecebf65b2: Update Phriction for handleRequest
Summary

Updates Phriction calls to handleRequest

Test Plan

Create, Delete, Move a Phriction Document. Check history, diff.

Diff Detail

Repository
rP Phabricator
Branch
phriction1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7352
Build 7744: [Placeholder Plan] Wait for 30 Seconds
Build 7743: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33066.Jul 22 2015, 7:46 PM
chad retitled this revision from to Update Phriction for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 22 2015, 7:46 PM
chad added a task: T8628: Modernize AphrontControllers to implement handleRequest.Jul 22 2015, 7:48 PM
epriestley accepted this revision.Jul 22 2015, 8:19 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phriction/controller/PhrictionDiffController.php
259

Or $this->getViewer().

This revision is now accepted and ready to land.Jul 22 2015, 8:19 PM
Closed by commit rP96cecebf65b2: Update Phriction for handleRequest (authored by chad, committed by chad). · Explain WhyJul 22 2015, 8:25 PM
This revision was automatically updated to reflect the committed changes.
chad marked an inline comment as done.

Revision Contents
Changeset List

Diff 33066

View Options

src/applications/phriction/controller/PhrictionDeleteController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDiffController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionEditController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionHistoryController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionListController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionNewController.php

Loading...
Phabricator · Built by Phacility