Page MenuHomePhabricator
Differential D13679

Update Ponder for handleRequest
ClosedPublic
Actions

Authored by chad on Jul 22 2015, 6:35 PM.
Tags
None
Referenced Files
F13245573: D13679.diff
Thu, May 23, 6:06 AM
F13223646: D13679.diff
Sun, May 19, 4:46 AM
F13205670: D13679.diff
Wed, May 15, 2:16 AM
F13190303: D13679.diff
Sat, May 11, 9:30 AM
Unknown Object (File)
Tue, May 7, 10:02 AM
Unknown Object (File)
Fri, May 3, 10:01 AM
Unknown Object (File)
Wed, May 1, 2:00 PM
Unknown Object (File)
Thu, Apr 25, 3:25 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rP1aed0e67a9a9: Update Ponder for handleRequest
Summary

Update all Ponder callsites.

Test Plan

New Question, New Comment, New Answer, Vote Up and Down

Diff Detail

Repository
rP Phabricator
Branch
ponder1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7349
Build 7738: [Placeholder Plan] Wait for 30 Seconds
Build 7737: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33063.Jul 22 2015, 6:35 PM
chad retitled this revision from to Update Ponder for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 22 2015, 6:35 PM
chad added a task: T8628: Modernize AphrontControllers to implement handleRequest.Jul 22 2015, 7:48 PM
epriestley accepted this revision.Jul 22 2015, 8:21 PM
epriestley edited edge metadata.

One catch, see inline.

src/applications/ponder/controller/PonderQuestionListController.php
10

should likely remain getURIData('queryKey').

This revision is now accepted and ready to land.Jul 22 2015, 8:21 PM
Closed by commit rP1aed0e67a9a9: Update Ponder for handleRequest (authored by chad, committed by chad). · Explain WhyJul 22 2015, 8:23 PM
This revision was automatically updated to reflect the committed changes.
chad marked an inline comment as done.

Revision Contents
Changeset List

Diff 33063

View Options

src/applications/ponder/controller/PonderAnswerCommentController.php

Loading...
View Options

src/applications/ponder/controller/PonderAnswerEditController.php

Loading...
View Options

src/applications/ponder/controller/PonderAnswerHistoryController.php

Loading...
View Options

src/applications/ponder/controller/PonderAnswerSaveController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionCommentController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionEditController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionHistoryController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionListController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionStatusController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/applications/ponder/controller/PonderVoteSaveController.php

Loading...
Phabricator · Built by Phacility