Page MenuHomePhabricator
Differential D13675

Improve the declaration parentheses linting
ClosedPublic
Actions

Authored by joshuaspence on Jul 22 2015, 9:11 AM.
Tags
None
Referenced Files
F13327417: D13675.diff
Sat, Jun 15, 7:03 PM
F13273897: D13675.diff
Fri, May 31, 2:56 AM
F13259851: D13675.diff
Sun, May 26, 11:10 PM
F13210248: D13675.diff
May 17 2024, 4:38 AM
F13195025: D13675.diff
May 12 2024, 10:04 PM
Unknown Object (File)
May 3 2024, 2:14 AM
Unknown Object (File)
Apr 29 2024, 1:37 PM
Unknown Object (File)
Apr 24 2024, 9:50 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCe286ef66c8ce: Improve the declaration parentheses linting
Summary

Improve ArcanistClosingDeclarationParenthesesXHPASTLinterRule (and rename it to ArcanistDeclarationParenthesesXHPASTLinterRule) to ensure that there is no whitespace before the opening parenthesis of a function/method declaration.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33049.Jul 22 2015, 9:11 AM
joshuaspence retitled this revision from to Improve the declaration parentheses linting.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 22 2015, 9:11 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 22 2015, 2:08 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2015, 2:08 PM
Closed by commit rARCe286ef66c8ce: Improve the declaration parentheses linting (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 22 2015, 8:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
lint/
linter/
__tests__/
xhpast/
21 lines
xhpast/
rules/
ArcanistDeclarationParenthesesXHPASTLinterRule.php
ArcanistClosingDeclarationParenthesesXHPASTLinterRule.php
19 lines

Diff 33079

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/decl-parens-hug-closing.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistClosingDeclarationParenthesesXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistDeclarationParenthesesXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility