Page MenuHomePhabricator
Differential D13675

Improve the declaration parentheses linting
ClosedPublic
Actions

Authored by joshuaspence on Jul 22 2015, 9:11 AM.
Tags
None
Referenced Files
F15533237: D13675.id33049.diff
Wed, Apr 23, 6:50 PM
F15532071: D13675.id.diff
Wed, Apr 23, 2:23 PM
F15523423: D13675.diff
Mon, Apr 21, 1:22 AM
F15519482: D13675.id.diff
Sat, Apr 19, 11:34 PM
F15517115: D13675.id33049.diff
Sat, Apr 19, 12:39 AM
F15511902: D13675.id33079.diff
Thu, Apr 17, 6:14 AM
F15510590: D13675.id33079.diff
Wed, Apr 16, 8:27 PM
F15510588: D13675.id.diff
Wed, Apr 16, 8:27 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCe286ef66c8ce: Improve the declaration parentheses linting
Summary

Improve ArcanistClosingDeclarationParenthesesXHPASTLinterRule (and rename it to ArcanistDeclarationParenthesesXHPASTLinterRule) to ensure that there is no whitespace before the opening parenthesis of a function/method declaration.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7343
Build 7726: [Placeholder Plan] Wait for 30 Seconds
Build 7725: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33049.Jul 22 2015, 9:11 AM
joshuaspence retitled this revision from to Improve the declaration parentheses linting.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 22 2015, 9:11 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 22 2015, 2:08 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2015, 2:08 PM
Closed by commit rARCe286ef66c8ce: Improve the declaration parentheses linting (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 22 2015, 8:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
lint/
linter/
__tests__/
xhpast/
21 lines
xhpast/
rules/
ArcanistDeclarationParenthesesXHPASTLinterRule.php
ArcanistClosingDeclarationParenthesesXHPASTLinterRule.php
19 lines

Diff 33049

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/decl-parens-hug-closing.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistClosingDeclarationParenthesesXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistDeclarationParenthesesXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility