Page MenuHomePhabricator

Improve the declaration parentheses linting
ClosedPublic

Authored by joshuaspence on Jul 22 2015, 9:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 6:20 AM
Unknown Object (File)
Sun, Jan 26, 11:57 AM
Unknown Object (File)
Sun, Jan 26, 11:57 AM
Unknown Object (File)
Sun, Jan 26, 11:57 AM
Unknown Object (File)
Fri, Jan 24, 12:59 PM
Unknown Object (File)
Mon, Jan 13, 12:19 PM
Unknown Object (File)
Dec 26 2024, 6:35 AM
Unknown Object (File)
Dec 20 2024, 3:26 PM
Subscribers

Details

Summary

Improve ArcanistClosingDeclarationParenthesesXHPASTLinterRule (and rename it to ArcanistDeclarationParenthesesXHPASTLinterRule) to ensure that there is no whitespace before the opening parenthesis of a function/method declaration.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7343
Build 7726: [Placeholder Plan] Wait for 30 Seconds
Build 7725: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Improve the declaration parentheses linting.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2015, 2:08 PM
This revision was automatically updated to reflect the committed changes.