Page MenuHomePhabricator

Allow XHPAST to be viewed public
ClosedPublic

Authored by chad on Jul 22 2015, 5:01 AM.
Tags
None
Referenced Files
F14087516: D13674.diff
Sat, Nov 23, 10:17 PM
Unknown Object (File)
Wed, Nov 20, 3:41 PM
Unknown Object (File)
Sat, Nov 16, 1:51 AM
Unknown Object (File)
Tue, Nov 12, 3:48 PM
Unknown Object (File)
Thu, Nov 7, 7:51 PM
Unknown Object (File)
Mon, Oct 28, 8:11 AM
Unknown Object (File)
Oct 22 2024, 8:01 PM
Unknown Object (File)
Oct 16 2024, 7:03 PM
Subscribers

Details

Summary

Ref T4830. Not sure this should be public (consume resources?)

Test Plan

View logged out.

Diff Detail

Repository
rP Phabricator
Branch
phpast-pub
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7342
Build 7724: [Placeholder Plan] Wait for 30 Seconds
Build 7723: arc lint + arc unit

Event Timeline

chad retitled this revision from to Allow XHPAST to be viewed public.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2015, 2:04 PM
epriestley edited edge metadata.

Actually, I wouldn't let them use PhabricatorXHPASTViewRunController.php.

This revision now requires changes to proceed.Jul 22 2015, 2:05 PM

Basically, this app is super oldschool. Ideally we should:

  • Add Query + SearchEngine.
  • Have a standard list, make the list public, etc.
  • Proper "Create AST" button.

We'd keep "create AST" non-public, like other creation operations in other apps.

Just doing this change (without all that extra work, and without making RunController public) is fine, but it just means that sharing links to trees will work. The landing page for the app will still be nonfunctional for public users.

chad edited edge metadata.
  • remove from run controller
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2015, 8:22 PM
This revision was automatically updated to reflect the committed changes.