Page MenuHomePhabricator

Fix unitialized variable in ArcanistPhpunitTestResultParser
ClosedPublic

Authored by duraseb on Jul 16 2015, 4:03 PM.
Tags
None
Referenced Files
F15536424: D13640.id32968.diff
Thu, Apr 24, 9:39 AM
F15523711: D13640.id32964.diff
Mon, Apr 21, 3:07 AM
F15518948: D13640.id.diff
Sat, Apr 19, 6:23 PM
F15514543: D13640.id.diff
Fri, Apr 18, 3:33 AM
F15509497: D13640.diff
Wed, Apr 16, 12:53 PM
F15467177: D13640.id32968.diff
Thu, Apr 3, 1:29 PM
F15437925: D13640.id32964.diff
Mar 25 2025, 10:10 PM
F15416471: D13640.id32968.diff
Mar 20 2025, 11:20 AM

Details

Summary

This is to fix arc unit when running a test file with no test results (e.g. skipped)

EXCEPTION: (RuntimeException) Undefined variable: last_test_finished at [<phutil>/src/error/PhutilErrorHandler.php:210]
arcanist(head=master, ref.master=d54cb072facd), deviantart(), phutil(head=master, ref.master=75f675747648)
  #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<arcanist>/src/unit/parser/ArcanistPhpunitTestResultParser.php:95]
  #1 ArcanistPhpunitTestResultParser::parseTestResults(string, string) called at [<deviantart>/unit/DaUnitEngine.php:150]
  #2 DaUnitEngine::parseTestResults(string, TempFile, string, string) called at [<deviantart>/unit/DaUnitEngine.php:82]
  #3 DaUnitEngine::run() called at [<arcanist>/src/workflow/ArcanistUnitWorkflow.php:186]
  #4 ArcanistUnitWorkflow::run() called at [<arcanist>/scripts/arcanist.php:382]
Test Plan

Create a test file with skipped tests. Run arc unit. Make sure the exception is not thrown.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

duraseb retitled this revision from to Fix unitialized variable in ArcanistPhpunitTestResultParser.
duraseb updated this object.
duraseb edited the test plan for this revision. (Show Details)
duraseb added reviewers: epriestley, joshuaspence.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:39 PM
This revision was automatically updated to reflect the committed changes.