Page MenuHomePhabricator

Fix unitialized variable in ArcanistPhpunitTestResultParser
ClosedPublic

Authored by duraseb on Jul 16 2015, 4:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 9:34 AM
Unknown Object (File)
Thu, Nov 14, 9:55 AM
Unknown Object (File)
Sun, Nov 10, 8:41 AM
Unknown Object (File)
Tue, Nov 5, 8:30 PM
Unknown Object (File)
Sat, Oct 26, 6:18 AM
Unknown Object (File)
Oct 3 2024, 3:26 PM
Unknown Object (File)
Sep 12 2024, 7:51 AM
Unknown Object (File)
Sep 5 2024, 3:07 PM

Details

Summary

This is to fix arc unit when running a test file with no test results (e.g. skipped)

EXCEPTION: (RuntimeException) Undefined variable: last_test_finished at [<phutil>/src/error/PhutilErrorHandler.php:210]
arcanist(head=master, ref.master=d54cb072facd), deviantart(), phutil(head=master, ref.master=75f675747648)
  #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<arcanist>/src/unit/parser/ArcanistPhpunitTestResultParser.php:95]
  #1 ArcanistPhpunitTestResultParser::parseTestResults(string, string) called at [<deviantart>/unit/DaUnitEngine.php:150]
  #2 DaUnitEngine::parseTestResults(string, TempFile, string, string) called at [<deviantart>/unit/DaUnitEngine.php:82]
  #3 DaUnitEngine::run() called at [<arcanist>/src/workflow/ArcanistUnitWorkflow.php:186]
  #4 ArcanistUnitWorkflow::run() called at [<arcanist>/scripts/arcanist.php:382]
Test Plan

Create a test file with skipped tests. Run arc unit. Make sure the exception is not thrown.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

duraseb retitled this revision from to Fix unitialized variable in ArcanistPhpunitTestResultParser.
duraseb updated this object.
duraseb edited the test plan for this revision. (Show Details)
duraseb added reviewers: epriestley, joshuaspence.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:39 PM
This revision was automatically updated to reflect the committed changes.