Page MenuHomePhabricator
Differential D13637

Make test result parsing stricter about duration formats
ClosedPublic
Actions

Authored by epriestley on Jul 15 2015, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 4:02 AM
Unknown Object (File)
Mon, Apr 29, 8:51 PM
Unknown Object (File)
Mon, Apr 29, 3:32 PM
Unknown Object (File)
Thu, Apr 25, 12:00 AM
Unknown Object (File)
Tue, Apr 23, 4:17 AM
Unknown Object (File)
Thu, Apr 11, 8:16 AM
Unknown Object (File)
Mar 24 2024, 10:52 PM
Unknown Object (File)
Feb 8 2024, 12:21 AM
View All Files
Subscribers
champo
epriestley
jsotuyod
Tokens
"Mountain of Wealth" token, awarded by jsotuyod.

Details

Reviewers
joshuaspence
btrahan
chad
Maniphest Tasks
T8805: Improve error checking for third-party unit test engines
Commits
rARC5e578fb847b3: Make test result parsing stricter about duration formats
Summary

Fixes T8805. Explicitly require int/float for duration. Adjust XUnit/Go parsers to provide one.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
duration
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7284
Build 7607: [Placeholder Plan] Wait for 30 Seconds
Build 7606: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32957.Jul 15 2015, 7:34 PM
epriestley retitled this revision from to Make test result parsing stricter about duration formats.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad, joshuaspence.
epriestley added a task: T8805: Improve error checking for third-party unit test engines.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 15 2015, 7:34 PM
jsotuyod awarded a token.Jul 15 2015, 7:39 PM
champo added a subscriber: champo.Jul 15 2015, 7:40 PM
jsotuyod added a subscriber: jsotuyod.Jul 15 2015, 7:44 PM
chad accepted this revision.Jul 15 2015, 8:25 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 15 2015, 8:25 PM
Closed by commit rARC5e578fb847b3: Make test result parsing stricter about duration formats (authored by epriestley, committed by epriestley). · Explain WhyJul 15 2015, 8:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32957

View Options

src/unit/ArcanistUnitTestResult.php

Loading...
View Options

src/unit/parser/ArcanistGoTestResultParser.php

Loading...
View Options

src/unit/parser/ArcanistXUnitTestResultParser.php

Loading...
Phabricator · Built by Phacility