Page MenuHomePhabricator
Differential D13637

Make test result parsing stricter about duration formats
ClosedPublic
Actions

Authored by epriestley on Jul 15 2015, 7:34 PM.
Tags
None
Referenced Files
F14843918: D13637.id32959.diff
Sun, Feb 2, 11:17 AM
Unknown Object (File)
Fri, Jan 24, 7:36 AM
Unknown Object (File)
Fri, Jan 24, 7:36 AM
Unknown Object (File)
Fri, Jan 24, 7:36 AM
Unknown Object (File)
Tue, Jan 21, 3:10 PM
Unknown Object (File)
Tue, Jan 21, 12:05 PM
Unknown Object (File)
Tue, Jan 21, 9:17 AM
Unknown Object (File)
Sun, Jan 19, 9:21 AM
View All Files
Subscribers
champo
epriestley
jsotuyod
Tokens
"Mountain of Wealth" token, awarded by jsotuyod.

Details

Reviewers
joshuaspence
btrahan
chad
Maniphest Tasks
T8805: Improve error checking for third-party unit test engines
Commits
rARC5e578fb847b3: Make test result parsing stricter about duration formats
Summary

Fixes T8805. Explicitly require int/float for duration. Adjust XUnit/Go parsers to provide one.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32957.Jul 15 2015, 7:34 PM
epriestley retitled this revision from to Make test result parsing stricter about duration formats.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad, joshuaspence.
epriestley added a task: T8805: Improve error checking for third-party unit test engines.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 15 2015, 7:34 PM
jsotuyod awarded a token.Jul 15 2015, 7:39 PM
champo added a subscriber: champo.Jul 15 2015, 7:40 PM
jsotuyod added a subscriber: jsotuyod.Jul 15 2015, 7:44 PM
chad accepted this revision.Jul 15 2015, 8:25 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 15 2015, 8:25 PM
Closed by commit rARC5e578fb847b3: Make test result parsing stricter about duration formats (authored by epriestley, committed by epriestley). · Explain WhyJul 15 2015, 8:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32959

View Options

src/unit/ArcanistUnitTestResult.php

Loading...
View Options

src/unit/parser/ArcanistGoTestResultParser.php

Loading...
View Options

src/unit/parser/ArcanistXUnitTestResultParser.php

Loading...
Phabricator · Built by Phacility