Page MenuHomePhabricator
Differential D13630

Fix firefox workboard half-pixel issue
ClosedPublic
Actions

Authored by chad on Jul 14 2015, 6:34 PM.
Tags
None
Referenced Files
F14492599: D13630.diff
Thu, Jan 2, 8:55 PM
Unknown Object (File)
Tue, Dec 31, 5:56 PM
Unknown Object (File)
Tue, Dec 31, 8:58 AM
Unknown Object (File)
Mon, Dec 30, 9:38 PM
Unknown Object (File)
Fri, Dec 27, 5:52 PM
Unknown Object (File)
Sun, Dec 22, 10:46 AM
Unknown Object (File)
Mon, Dec 16, 8:02 PM
Unknown Object (File)
Sat, Dec 14, 4:50 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Baby Tequila" token, awarded by btrahan.

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8827: tear on workboard header line
Commits
Restricted Diffusion Commit
rP183dd2a62764: Fix firefox workboard half-pixel issue
Summary

Fixes T8827. Firefox and other browsers differ here. Going to make the header relative so boards always slide under it.

Test Plan

Test workboard with scrolling in FF and Chrome.

Diff Detail

Repository
rP Phabricator
Branch
ff-workboard
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7266
Build 7571: [Placeholder Plan] Wait for 30 Seconds
Build 7570: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32936.Jul 14 2015, 6:34 PM
chad retitled this revision from to Fix firefox workboard half-pixel issue.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8827: tear on workboard header line.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 14 2015, 6:34 PM
btrahan accepted this revision.Jul 16 2015, 8:37 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:37 PM
btrahan awarded a token.Jul 16 2015, 8:37 PM
Closed by commit rP183dd2a62764: Fix firefox workboard half-pixel issue (authored by chad, committed by chad). · Explain WhyJul 17 2015, 1:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
webroot/
rsrc/
css/
core/
4 lines
phui/
1 line

Diff 32936

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/z-index.css

Loading...
View Options

webroot/rsrc/css/phui/phui-workboard-view.css

Loading...
Phabricator · Built by Phacility