Page MenuHomePhabricator

Group and order Herald fields
ClosedPublic

Authored by epriestley on Jul 9 2015, 11:27 PM.
Tags
None
Referenced Files
F14005452: D13619.id32904.diff
Sun, Oct 27, 1:17 PM
F13999222: D13619.diff
Thu, Oct 24, 1:32 PM
F13982582: D13619.id32975.diff
Sun, Oct 20, 12:26 AM
Unknown Object (File)
Oct 2 2024, 1:19 AM
Unknown Object (File)
Sep 12 2024, 7:50 AM
Unknown Object (File)
Sep 5 2024, 3:01 PM
Unknown Object (File)
Sep 5 2024, 1:23 PM
Unknown Object (File)
Aug 29 2024, 12:15 PM
Subscribers
Tokens
"Like" token, awarded by eadler.

Details

Summary

Ref T8726. Some adapters now have a large number of fields, and we lost the sort-of-human-readable implicit ordering when fields were modularized.

Instead, group and sort fields.

Test Plan

Screen Shot 2015-07-09 at 4.02.19 PM.png (402×242 px, 40 KB)

Diff Detail

Repository
rP Phabricator
Branch
herald6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7237
Build 7516: [Placeholder Plan] Wait for 30 Seconds
Build 7515: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Group and order Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jul 14 2015, 3:01 PM
This revision was automatically updated to reflect the committed changes.