Page MenuHomePhabricator

Begin modularizing Herald field values
ClosedPublic

Authored by epriestley on Jul 9 2015, 4:06 PM.
Tags
None
Referenced Files
F18835183: D13613.diff
Sun, Oct 26, 2:04 PM
F18763487: D13613.id32895.diff
Tue, Oct 7, 12:25 AM
F18739304: D13613.diff
Wed, Oct 1, 8:49 PM
F18730140: D13613.id.diff
Tue, Sep 30, 12:14 PM
F18633634: D13613.diff
Sep 16 2025, 8:34 PM
F18629029: D13613.diff
Sep 16 2025, 7:51 AM
F18506221: D13613.id.diff
Sep 5 2025, 1:16 AM
F18498715: D13613.diff
Sep 4 2025, 6:59 PM
Subscribers

Details

Summary

Ref T8726. I'm primarily trying to modularize tokenizer values so we don't have to update JS to add a new one.

This is ultimately the blocker for "select" custom fields working in Herald.

This inches us toward that. I'm not modularizing conditions or control types in this round, but hope to end up with hard-coded conditions (which are highly general and very rarely change), hard-coded control types (which are also highly general and very rarely change) and completely modular fields and values (which have mid-to-low generality and change frequently).

Test Plan

Used UI to interact with "none", "text", and new-style "select" controls. No actual support for tokenizers yet.

Diff Detail

Repository
rP Phabricator
Branch
herald2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7230
Build 7502: [Placeholder Plan] Wait for 30 Seconds
Build 7501: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Begin modularizing Herald field values.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:39 PM
This revision was automatically updated to reflect the committed changes.