Paths

Table of Contentst

Differential D13577

Add a trivial test case for HeraldField
ClosedPublic
Actions

Authored by joshuaspence on Jul 7 2015, 1:02 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP0ffc7a8ab663: Add a trivial test case for HeraldField

Summary

Adds a trivial test case to ensure that HeraldField subclasses are properly implemented.

Test Plan

arc unit

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7178
Build 7401: [Placeholder Plan] Wait for 30 Seconds
Build 7400: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 32814.Jul 7 2015, 1:02 PM

joshuaspence retitled this revision from to Add a trivial test case for HeraldField.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 7 2015, 1:02 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jul 7 2015, 1:04 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 7 2015, 1:04 PM

Closed by commit rP0ffc7a8ab663: Add a trivial test case for HeraldField (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 7 2015, 1:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

__phutil_library_map__.php

2 lines

applications/

herald/

field/

__tests__/

HeraldFieldTestCase.php

10 lines

100%

Diff 32814

View Options

src/__phutil_library_map__.php

View Options

src/applications/herald/field/tests/HeraldFieldTestCase.php

Add a trivial test case for HeraldFieldClosedPublicActions