Differential D13559

Fix bin/lipsum
ClosedPublic
Actions

Authored by meitros on Jul 6 2015, 7:04 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP6a3c1ba05c91: Fix bin/lipsum

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Set a default edit policy to match view policy for projects
It seems like initializeNew* is a better init function than new Phabricator*, so ported two classes to use it and spot-checked the others (this also fixed a fatal.)
Other minor bugs

Test Plan

Ran lipsum for a while without any fatals

Diff Detail

Repository

rP Phabricator

Branch

fixlipsum

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7155
Build 7355: [Placeholder Plan] Wait for 30 Seconds
Build 7354: arc lint + arc unit

Event Timeline

meitros updated this revision to Diff 32760.Jul 6 2015, 7:04 AM

meitros retitled this revision from to Fix bin/lipsum.

meitros updated this object.

meitros edited the test plan for this revision. (Show Details)

meitros added a reviewer: epriestley.

meitros added a subscriber: jhurwitz.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 6 2015, 7:04 AM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jul 6 2015, 5:49 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 6 2015, 5:49 PM

Having trouble landing this (git push 403s). I double checked the contributor guide, added my ssh-key to my account, tried setting my remote url to both the https and ssh remote url on the rPhabricator diffusion page:

Exception: You do not have permission to push to this repository.

I also spent a few minutes looking up your fax number to just fax the diff over, but there doesn't seem to be one online...did you drop support for this?