[Redesign] Clean up <select>
ClosedPublic
Actions

Authored by chad on Jul 2 2015, 1:27 AM.

Tags

None

Referenced Files

	F15491966: D13523.diff
	Sat, Apr 12, 9:25 AM

	F15473998: D13523.id32691.diff
	Sun, Apr 6, 3:50 AM

	F15457606: D13523.id32691.diff
	Sun, Mar 30, 5:20 PM

	F15454804: D13523.id32712.diff
	Sat, Mar 29, 8:32 PM

	F15452049: D13523.id32691.diff
	Sat, Mar 29, 1:25 AM

	F15449301: D13523.id.diff
	Fri, Mar 28, 9:21 AM

	F15442827: D13523.diff
	Thu, Mar 27, 12:42 AM

	F15438356: D13523.id32691.diff
	Wed, Mar 26, 12:19 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign
T8449: Spaces v1 Errata

Commits

Restricted Diffusion Commit
rP18e1bd2e459d: [Redesign] Clean up <select>

Summary

Ref T8099, Ref T8449. Adds a min width to selects (can't think of anything this breaks in ui) and adds space around space select.

Test Plan

Review a number of selects in different UIs, forms, dialogs.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 32691.Jul 2 2015, 1:27 AM

chad retitled this revision from to [Redesign] Clean up <select>.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added tasks: T8449: Spaces v1 Errata, T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 2 2015, 1:27 AM

epriestley accepted this revision.Jul 2 2015, 9:24 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 2 2015, 9:24 PM

Closed by commit rP18e1bd2e459d: [Redesign] Clean up <select> (authored by chad, committed by chad). · Explain WhyJul 2 2015, 9:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

src/

view/

form/

control/

AphrontFormPolicyControl.php

1 line

webroot/

rsrc/

css/

phui/

phui-form.css

11 lines

Diff 32712

View Options

resources/celerity/map.php

View Options

src/view/form/control/AphrontFormPolicyControl.php

View Options

webroot/rsrc/css/phui/phui-form.css

[Redesign] Clean up <select>ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32712

resources/celerity/map.php

src/view/form/control/AphrontFormPolicyControl.php

webroot/rsrc/css/phui/phui-form.css

[Redesign] Clean up <select>
ClosedPublic
Actions

Revision Contents
Changeset List