Page MenuHomePhabricator
Differential D13523

[Redesign] Clean up <select>
ClosedPublic
Actions

Authored by chad on Jul 2 2015, 1:27 AM.

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
T8449: Spaces v1 Errata
Commits
Restricted Diffusion Commit
rP18e1bd2e459d: [Redesign] Clean up <select>
Summary

Ref T8099, Ref T8449. Adds a min width to selects (can't think of anything this breaks in ui) and adds space around space select.

Test Plan

Review a number of selects in different UIs, forms, dialogs.

Diff Detail

Repository
rP Phabricator
Branch
spaces
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7106
Build 7264: [Placeholder Plan] Wait for 30 Seconds
Build 7263: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32691.Jul 2 2015, 1:27 AM
chad retitled this revision from to [Redesign] Clean up <select>.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added tasks: T8449: Spaces v1 Errata, T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 2 2015, 1:27 AM
epriestley accepted this revision.Jul 2 2015, 9:24 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 2 2015, 9:24 PM
Closed by commit rP18e1bd2e459d: [Redesign] Clean up <select> (authored by chad, committed by chad). · Explain WhyJul 2 2015, 9:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
form/
control/
1 line
webroot/
rsrc/
css/
phui/
11 lines

Diff 32691

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/AphrontFormPolicyControl.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form.css

Loading...
Phabricator · Built by Phacility