Fix infinite loop in renderAccessDenied()
ClosedPublic
Actions

Authored by epriestley on Jun 30 2015, 6:35 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8727: Infinite query when failing to view a reivsion

Commits

Restricted Diffusion Commit
rP1bb306348c01: Fix infinite loop in renderAccessDenied()

Summary

Fixes T8727. When I added setParentQuery(), I increased the cache hit rate but also accidentally propagated policy exception settings.

Instead, make the policy exception beahvior explicit: no exceptions should be raised when querying handles.

Test Plan

Will test production.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32636.Jun 30 2015, 6:35 PM

epriestley retitled this revision from to Fix infinite loop in renderAccessDenied().

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8727: Infinite query when failing to view a reivsion.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 6:35 PM

btrahan accepted this revision.Jun 30 2015, 6:42 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 30 2015, 6:42 PM

Closed by commit rP1bb306348c01: Fix infinite loop in renderAccessDenied() (authored by epriestley, committed by epriestley). · Explain WhyJun 30 2015, 6:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phid/

query/

PhabricatorHandleQuery.php

6 lines

Diff 32637

View Options

src/applications/phid/query/PhabricatorHandleQuery.php

Fix infinite loop in renderAccessDenied()ClosedPublicActions