Page MenuHomePhabricator

Fix infinite loop in renderAccessDenied()
ClosedPublic

Authored by epriestley on Jun 30 2015, 6:35 PM.
Tags
None
Referenced Files
F14173381: D13489.diff
Sun, Dec 8, 9:37 AM
F14168788: D13489.id32636.diff
Sat, Dec 7, 2:19 PM
Unknown Object (File)
Fri, Dec 6, 4:23 AM
Unknown Object (File)
Thu, Dec 5, 10:38 AM
Unknown Object (File)
Mon, Dec 2, 7:53 PM
Unknown Object (File)
Sat, Nov 23, 11:38 PM
Unknown Object (File)
Oct 19 2024, 6:31 PM
Unknown Object (File)
Oct 18 2024, 6:26 PM
Subscribers

Details

Summary

Fixes T8727. When I added setParentQuery(), I increased the cache hit rate but also accidentally propagated policy exception settings.

Instead, make the policy exception beahvior explicit: no exceptions should be raised when querying handles.

Test Plan

Will test production.

Diff Detail

Repository
rP Phabricator
Branch
loop1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7066
Build 7185: [Placeholder Plan] Wait for 30 Seconds
Build 7184: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix infinite loop in renderAccessDenied().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2015, 6:42 PM
This revision was automatically updated to reflect the committed changes.