Page MenuHomePhabricator

Fix infinite loop in renderAccessDenied()
ClosedPublic

Authored by epriestley on Jun 30 2015, 6:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 3 2025, 7:50 PM
Unknown Object (File)
May 29 2025, 4:33 AM
Unknown Object (File)
May 27 2025, 6:57 PM
Unknown Object (File)
May 26 2025, 6:09 AM
Unknown Object (File)
May 20 2025, 7:53 PM
Unknown Object (File)
May 19 2025, 7:21 PM
Unknown Object (File)
May 9 2025, 9:28 PM
Unknown Object (File)
May 7 2025, 8:52 PM
Subscribers

Details

Summary

Fixes T8727. When I added setParentQuery(), I increased the cache hit rate but also accidentally propagated policy exception settings.

Instead, make the policy exception beahvior explicit: no exceptions should be raised when querying handles.

Test Plan

Will test production.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix infinite loop in renderAccessDenied().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2015, 6:42 PM
This revision was automatically updated to reflect the committed changes.