Page MenuHomePhabricator
Differential D13485

Don't put the entire corpus into project edit feed stories
ClosedPublic
Actions

Authored by epriestley on Jun 30 2015, 12:43 PM.
Tags
None
Referenced Files
F15543732: D13485.id32623.diff
Sat, Apr 26, 12:41 AM
F15538048: D13485.diff
Thu, Apr 24, 5:13 PM
F15525909: D13485.id32623.diff
Mon, Apr 21, 5:44 PM
F15525869: D13485.id32624.diff
Mon, Apr 21, 5:24 PM
F15515900: D13485.id.diff
Fri, Apr 18, 2:18 PM
F15513641: D13485.diff
Thu, Apr 17, 8:34 PM
F15490142: D13485.diff
Fri, Apr 11, 2:41 PM
F15478546: D13485.diff
Tue, Apr 8, 1:00 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T8723: Issue with project description notification being too long
Commits
Restricted Diffusion Commit
rP12c6e63d5bad: Don't put the entire corpus into project edit feed stories
Summary

Fixes T8723. We override timeline titles for these fields to shorten them, but the parent class shows full values for feed edits, which can lead to screen-sized notifications.

Test Plan

Edited a project, saw a reasonably-sized notification for it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32623.Jun 30 2015, 12:43 PM
epriestley retitled this revision from to Don't put the entire corpus into project edit feed stories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8723: Issue with project description notification being too long.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 12:43 PM
chad accepted this revision.Jun 30 2015, 12:57 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jun 30 2015, 12:57 PM
Closed by commit rP12c6e63d5bad: Don't put the entire corpus into project edit feed stories (authored by epriestley, committed by epriestley). · Explain WhyJun 30 2015, 1:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
customfield/
standard/
11 lines

Diff 32624

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php

Loading...
Phabricator · Built by Phacility