Page MenuHomePhabricator

Don't put the entire corpus into project edit feed stories
ClosedPublic

Authored by epriestley on Jun 30 2015, 12:43 PM.
Tags
None
Referenced Files
F12838219: D13485.id32623.diff
Thu, Mar 28, 6:01 PM
Unknown Object (File)
Tue, Mar 5, 2:54 AM
Unknown Object (File)
Jan 30 2024, 3:40 PM
Unknown Object (File)
Jan 29 2024, 2:47 AM
Unknown Object (File)
Jan 28 2024, 2:37 AM
Unknown Object (File)
Dec 28 2023, 5:35 PM
Unknown Object (File)
Dec 21 2023, 9:13 AM
Unknown Object (File)
Dec 20 2023, 3:55 PM
Subscribers

Details

Summary

Fixes T8723. We override timeline titles for these fields to shorten them, but the parent class shows full values for feed edits, which can lead to screen-sized notifications.

Test Plan

Edited a project, saw a reasonably-sized notification for it.

Diff Detail

Repository
rP Phabricator
Branch
longnotification
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7060
Build 7173: [Placeholder Plan] Wait for 30 Seconds
Build 7172: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Don't put the entire corpus into project edit feed stories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jun 30 2015, 12:57 PM
This revision was automatically updated to reflect the committed changes.