Page MenuHomePhabricator

Don't put the entire corpus into project edit feed stories
ClosedPublic

Authored by epriestley on Jun 30 2015, 12:43 PM.
Tags
None
Referenced Files
F11014550: D13485.id32623.diff
Tue, Aug 9, 4:08 AM
F11012984: D13485.diff
Mon, Aug 8, 5:52 PM
F11011960: D13485.id32624.diff
Mon, Aug 8, 12:01 PM
Unknown Object (File)
Sat, Aug 6, 7:58 PM
Unknown Object (File)
Sat, Jul 30, 3:14 PM
Unknown Object (File)
Thu, Jul 28, 6:27 PM
Unknown Object (File)
Tue, Jul 26, 3:04 AM
Unknown Object (File)
Tue, Jul 19, 12:51 AM
Subscribers

Details

Summary

Fixes T8723. We override timeline titles for these fields to shorten them, but the parent class shows full values for feed edits, which can lead to screen-sized notifications.

Test Plan

Edited a project, saw a reasonably-sized notification for it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't put the entire corpus into project edit feed stories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jun 30 2015, 12:57 PM
This revision was automatically updated to reflect the committed changes.