Paths

Table of Contentst

Differential D13482

Let PhabricatorPlatformSite catch unconfigured requests
ClosedPublic
Actions

Authored by avivey on Jun 30 2015, 3:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jul 19, 1:28 PM

	Unknown Object (File)
	Mon, Jul 15, 3:37 PM

	Unknown Object (File)
	Sat, Jul 13, 3:05 AM

	Unknown Object (File)
	Wed, Jul 10, 7:20 AM

	Unknown Object (File)
	Tue, Jul 9, 11:51 AM

	Unknown Object (File)
	Mon, Jul 8, 12:04 PM

	Unknown Object (File)
	Sat, Jul 6, 12:34 AM

	Unknown Object (File)
	Fri, Jul 5, 10:20 PM

Subscribers

Details

Reviewers

epriestley
laomoi

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8717: Bad error when first installing phabricator

Commits

Restricted Diffusion Commit
rP9eda21451a44: Let PhabricatorPlatformSite catch unconfigured requests

Summary

Fix T8717. If the install didn't configure base-uri, assume they want Phabricator; We'll later show the setup warning about it.

Test Plan

Set base-uri to something else, see short error. Delete it, see Phabricator.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey updated this revision to Diff 32620.Jun 30 2015, 3:59 AM

avivey retitled this revision from to Let PhabricatorPlatformSite catch unconfigured requests.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a reviewer: epriestley.

avivey added a task: T8717: Bad error when first installing phabricator.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 30 2015, 3:59 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

avivey updated this object.Jun 30 2015, 3:59 AM

avivey edited edge metadata.

cool code , for test

Oh, sorry, I missed this. See D13483. I'm just going to land that change as this, since they're functionally identical except for meaningless base uri 0.

This revision is now accepted and ready to land.Jun 30 2015, 2:23 PM

epriestley mentioned this in D13483: Return the PlatformSite if no base URI is configured yet.Jun 30 2015, 2:23 PM

Closed by commit rP9eda21451a44: Let PhabricatorPlatformSite catch unconfigured requests (authored by epriestley, committed by epriestley). · Explain WhyJun 30 2015, 2:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

site/

PhabricatorPlatformSite.php

9 lines

Diff 32628

src/aphront/site/PhabricatorPlatformSite.php

Loading...