Page MenuHomePhabricator

show key name when map value is of wrong type
ClosedPublic

Authored by avivey on Jun 26 2015, 6:20 PM.
Tags
None
Referenced Files
F15503380: D13458.diff
Mon, Apr 14, 9:34 AM
F15463202: D13458.id.diff
Tue, Apr 1, 9:23 PM
F15461442: D13458.diff
Tue, Apr 1, 8:23 AM
F15451680: D13458.id32571.diff
Fri, Mar 28, 11:19 PM
F15450213: D13458.id32577.diff
Fri, Mar 28, 2:34 PM
F15449016: D13458.id.diff
Fri, Mar 28, 8:11 AM
F15445524: D13458.diff
Thu, Mar 27, 2:21 PM
F15440438: D13458.id32571.diff
Wed, Mar 26, 12:50 PM

Details

Test Plan

before:

$ arc lint
Exception
Error in parsing '.arclint' file, for linter 'Anonymizable fields'.
Parameter has invalid type. Expected a regular expression, but value is not valid: preg_match(): Delimiter must not be alphanumeric or backslash
(Run with `--trace` for a full exception trace.)

after:

$ arc lint
Exception
Error in parsing '.arclint' file, for linter 'Anonymizable fields'.
Parameter 'script-and-regex.regex' has invalid type. Expected a regular expression, but value is not valid: preg_match(): Delimiter must not be alphanumeric or backslash
(Run with `--trace` for a full exception trace.)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey retitled this revision from to show key name when map value is of wrong type.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: epriestley, joshuaspence.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 26 2015, 8:21 PM
This revision was automatically updated to reflect the committed changes.