Use PhutilClassMapQuery where appropriate.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPHU12bd645b58b9: Use PhutilClassMapQuery
Not quite sure.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 6996 Build 7048: [Placeholder Plan] Wait for 30 Seconds Build 7047: arc lint + arc unit
Event Timeline
Comment Actions
This is not quite correct: translations do not have unique locale codes, and it's OK for a bunch of translations to translate the same locale.
The use case here is if you develop a third-party application like "SuperCountdown", you might want to translate it into BritishEnglish. You can add a translation file to your application and distribute it with the rest of your code, with just your application's strings, and it will supplement the existing main translation file.
This should be OK without the setUniqueMethod() call.
| src/internationalization/PhutilTranslation.php | ||
|---|---|---|
| 72–74 | This part is potentially combining the maps for a bunch of third-party code. | |