Page MenuHomePhabricator

Use PhutilClassMapQuery
ClosedPublic

Authored by joshuaspence on Jun 25 2015, 12:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 11, 9:33 PM
Unknown Object (File)
Sat, Feb 8, 3:10 PM
Unknown Object (File)
Sat, Feb 8, 3:09 PM
Unknown Object (File)
Sat, Feb 8, 3:09 PM
Unknown Object (File)
Sat, Feb 8, 3:08 PM
Unknown Object (File)
Tue, Feb 4, 10:14 PM
Unknown Object (File)
Sun, Feb 2, 12:22 AM
Unknown Object (File)
Fri, Jan 31, 5:07 PM
Subscribers

Details

Summary

Use PhutilClassMapQuery where appropriate.

Test Plan

Not quite sure.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Use PhutilClassMapQuery.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

This is not quite correct: translations do not have unique locale codes, and it's OK for a bunch of translations to translate the same locale.

The use case here is if you develop a third-party application like "SuperCountdown", you might want to translate it into BritishEnglish. You can add a translation file to your application and distribute it with the rest of your code, with just your application's strings, and it will supplement the existing main translation file.

This should be OK without the setUniqueMethod() call.

src/internationalization/PhutilTranslation.php
72–74

This part is potentially combining the maps for a bunch of third-party code.

This revision now requires changes to proceed.Jun 25 2015, 12:15 PM
joshuaspence edited edge metadata.

Retain original behavior

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 25 2015, 12:22 PM
This revision was automatically updated to reflect the committed changes.