Page MenuHomePhabricator

Use PhutilClassMapQuery
ClosedPublic

Authored by joshuaspence on Jun 25 2015, 12:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 2:00 PM
Unknown Object (File)
Feb 18 2024, 6:47 PM
Unknown Object (File)
Jan 29 2024, 9:41 AM
Unknown Object (File)
Jan 28 2024, 5:33 AM
Unknown Object (File)
Jan 7 2024, 2:45 PM
Unknown Object (File)
Jan 7 2024, 2:45 PM
Unknown Object (File)
Dec 27 2023, 6:27 AM
Unknown Object (File)
Dec 26 2023, 6:51 PM
Subscribers

Details

Summary

Use PhutilClassMapQuery where appropriate.

Test Plan

Not quite sure.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Use PhutilClassMapQuery.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

This is not quite correct: translations do not have unique locale codes, and it's OK for a bunch of translations to translate the same locale.

The use case here is if you develop a third-party application like "SuperCountdown", you might want to translate it into BritishEnglish. You can add a translation file to your application and distribute it with the rest of your code, with just your application's strings, and it will supplement the existing main translation file.

This should be OK without the setUniqueMethod() call.

src/internationalization/PhutilTranslation.php
72–74

This part is potentially combining the maps for a bunch of third-party code.

This revision now requires changes to proceed.Jun 25 2015, 12:15 PM
joshuaspence edited edge metadata.

Retain original behavior

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 25 2015, 12:22 PM
This revision was automatically updated to reflect the committed changes.