Page MenuHomePhabricator

Add a linter rule for the use of `dirname(__FILE__)`
Needs ReviewPublic

Authored by joshuaspence on Jun 25 2015, 11:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 3:07 PM
Unknown Object (File)
Sat, Feb 8, 3:06 PM
Unknown Object (File)
Sat, Feb 8, 3:06 PM
Unknown Object (File)
Sat, Feb 8, 3:05 PM
Unknown Object (File)
Fri, Feb 7, 10:47 PM
Unknown Object (File)
Mon, Feb 3, 2:48 PM
Unknown Object (File)
Jan 27 2025, 6:05 AM
Unknown Object (File)
Jan 24 2025, 6:47 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

In PHP 5.4 and above, __DIR__ should be used instead of dirname(__FILE__). Add a linter rule to enforce this.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 6993
Build 7042: [Placeholder Plan] Wait for 30 Seconds
Build 7041: arc lint + arc unit

Unit TestsFailed

TimeTest
1,703 msArcanistJSHintLinterTestCase::testLinter
1,048 msArcanistCSSLintLinterTestCase::testLinter
205 msArcanistCSSLintLinterTestCase::testVersion
233 msArcanistChmodLinterTestCase::testLinter
530 msArcanistClosureLinterTestCase::testLinter
View Full Test Results (1 Failed · 48 Passed · 9 Skipped)

Event Timeline

joshuaspence retitled this revision from to Add a linter rule for the use of `dirname(__FILE__)`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.