Paths

Table of Contentst

Differential D13426

Add a linter rule for the use of `dirname(FILE)`
Needs ReviewPublic
Actions

Authored by joshuaspence on Jun 25 2015, 11:39 AM.

Tags

None

Referenced Files

	F15471953: D13426.id32509.diff
	Sat, Apr 5, 9:58 AM

	F15454752: D13426.id32509.diff
	Sat, Mar 29, 8:11 PM

	F15445200: D13426.id33583.diff
	Thu, Mar 27, 12:49 PM

	F15445133: D13426.id.diff
	Thu, Mar 27, 12:31 PM

	F15438874: D13426.diff
	Wed, Mar 26, 4:14 AM

	F15432273: D13426.id.diff
	Mon, Mar 24, 5:12 PM

	F15429340: D13426.id33583.diff
	Mon, Mar 24, 1:44 AM

	F15409257: D13426.id32509.diff
	Wed, Mar 19, 3:50 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

In PHP 5.4 and above, __DIR__ should be used instead of dirname(__FILE__). Add a linter rule to enforce this.

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7653
Build 8344: [Placeholder Plan] Wait for 30 Seconds
Build 8343: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,612 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	454 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	8,226 ms	ArcanistXHPASTLinterTestCase::Unknown Unit Message ("")
	124 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	786 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (3 Failed · 36 Passed · 19 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 32509.Jun 25 2015, 11:39 AM

joshuaspence retitled this revision from to Add a linter rule for the use of `dirname(__FILE__)`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 25 2015, 11:39 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Rebase

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

__phutil_library_map__.php

2 lines

-

-

lint/

linter/

__tests__/

xhpast/

dirname-file.lint-test

20 lines

-

-

xhpast/

rules/

ArcanistDirMagicConstantXHPASTLinterRule.php

57 lines

33%

Loading...

Diff 33583

src/__phutil_library_map__.php

Loading...

src/lint/linter/tests/xhpast/dirname-file.lint-test

Loading...

src/lint/linter/xhpast/rules/ArcanistDirMagicConstantXHPASTLinterRule.php

Loading...