Page MenuHomePhabricator
Differential D13414

Support Spaces in Diffusion
ClosedPublic
Actions

Authored by epriestley on Jun 24 2015, 1:18 PM.
Tags
None
Referenced Files
F14144435: D13414.id32486.diff
Tue, Dec 3, 8:19 PM
F14141276: D13414.diff
Tue, Dec 3, 10:16 AM
Unknown Object (File)
Fri, Nov 29, 4:01 AM
Unknown Object (File)
Thu, Nov 28, 8:13 PM
Unknown Object (File)
Tue, Nov 26, 1:19 PM
Unknown Object (File)
Sun, Nov 24, 5:20 PM
Unknown Object (File)
Thu, Nov 21, 9:45 AM
Unknown Object (File)
Sat, Nov 9, 9:26 AM
View All Files
Subscribers
epriestley
joshuaspence

Details

Reviewers
btrahan
Maniphest Tasks
T8493: Integrate Spaces into more applications
Commits
Restricted Diffusion Commit
rPfcb35a55fd23: Support Spaces in Diffusion
Summary

Ref T8493. Diffusion is probably the strongest upstream use case we have for Spaces right now, so I want to get us on it to kick the tires a bit.

Small amount of hackiness around the multi-page form thing but it shouldn't create any problems.

Test Plan
  • Created a new repo.
  • Edited a repo.
  • Tried invalid edits, saw value preserved.
  • Viewed edit full detail screen, saw space info.
  • Viewed repo detail view, saw space.
  • Viewed repo list view, saw space.

Diff Detail

Repository
rP Phabricator
Branch
spaces1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6974
Build 7008: [Placeholder Plan] Wait for 30 Seconds
Build 7007: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32486.Jun 24 2015, 1:18 PM
epriestley retitled this revision from to Support Spaces in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8493: Integrate Spaces into more applications.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 24 2015, 1:18 PM
btrahan accepted this revision.Jun 24 2015, 4:21 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 24 2015, 4:21 PM
Closed by commit rPfcb35a55fd23: Support Spaces in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyJun 24 2015, 5:56 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a subscriber: joshuaspence.Jun 24 2015, 9:52 PM

How does this work with callsigns? They still must be globally unique I presume?

epriestley added a comment.Jun 24 2015, 9:53 PM

Yes. Project names, callsigns, usernames, etc., all still need to be globally unique.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
1 line
applications/
diffusion/
controller/
36 lines
10 lines
repository/
query/
1 line
storage/
16 lines
view/
form/
control/
16 lines

Diff 32486

View Options

resources/sql/autopatches/20150624.spaces.1.repo.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/view/form/control/AphrontFormPolicyControl.php

Loading...
Phabricator · Built by Phacility